[6.x] Add CookieValuePrefix detection for encrypted cookies in InteractsWit… #804
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Laravel prefixes cookie values when being encrypted.
The dusk InteractsWithCookie trait does not have any of this prefix logic. Because of this
$browser->cookie('cookieKey')
would return the prefixed value and not the actual value.Example:
When calling
$browser->cookie('myCookieKey');
on an encrypted cookie you would get the following value (from the cookie function on the browser object):45093d44140e0247922e316851885c13445a6fcd|MYCOOKIEVALUE
In our tests we expected this cookie value to be unprefixed.
MYCOOKIEVALUE
The prefix is set by laravel in the Encrypt function of
Illuminate\Cookie\Middleware\EncryptCookies
Fix: This fix checks if the decrypted cookie value contains a prefix. In case the value is prefixed the prefix will be removed.